On Wed, Jun 21, 2017 at 09:57:18AM +0200, Thomas Monjalon wrote: > 21/06/2017 01:36, Gaetan Rivet: > > pmdinfogen has a dependency on the PCI bus. The latter must be built > > first. > > I think it should not be moved outside of buildtools. >
Right, I agree. I took the simplest path here, but if there is a better solution to be found I'd prefer to use it. > The build order can be fixed by installing headers before any compilation > like proposed in this RFC: http://dpdk.org/patch/25463 > This RFC should be discussed on its own merit, I will chime in the relevant thread. > Another (probably better) solution is to keep basic definitions > and helpers in EAL: > - rte_pci.h keeps only some PCI definitions and helpers > like rte_pci_addr and eal_parse_pci_BDF() in EAL > - bus management is done in the PCI driver > > For pmdinfogen, we just need struct rte_pci_id. > Other tools or applications will probably need this kind of basic > struct and functions available in EAL. I mostly agree, this proposal should be kept to a minimum at first for this release and carefully expanded afterward. If that's ok, I will propose a new version of this patchset with a new librte_pci, that might fix both pmdinfogen and librte_kni. -- Gaëtan Rivet 6WIND
