-----Original Message----- > Date: Fri, 23 Jun 2017 12:53:05 +0000 > From: "Van Haaren, Harry" <harry.van.haa...@intel.com> > To: Jerin Jacob <jerin.ja...@caviumnetworks.com>, "dev@dpdk.org" > <dev@dpdk.org> > CC: "Richardson, Bruce" <bruce.richard...@intel.com>, > "hemant.agra...@nxp.com" <hemant.agra...@nxp.com>, "Eads, Gage" > <gage.e...@intel.com>, "nipun.gu...@nxp.com" <nipun.gu...@nxp.com>, > "Vangati, Narender" <narender.vang...@intel.com>, "Rao, Nikhil" > <nikhil....@intel.com>, "gprathyu...@caviumnetworks.com" > <gprathyu...@caviumnetworks.com>, "Mcnamara, John" > <john.mcnam...@intel.com> > Subject: RE: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test > application > > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Sent: Sunday, May 28, 2017 8:59 PM > > To: dev@dpdk.org > > Cc: Richardson, Bruce <bruce.richard...@intel.com>; Van Haaren, Harry > > <harry.van.haa...@intel.com>; hemant.agra...@nxp.com; Eads, Gage > > <gage.e...@intel.com>; > > nipun.gu...@nxp.com; Vangati, Narender <narender.vang...@intel.com>; Rao, > > Nikhil > > <nikhil....@intel.com>; gprathyu...@caviumnetworks.com; Mcnamara, John > > <john.mcnam...@intel.com>; Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Subject: [dpdk-dev] [PATCH 28/33] doc: describe the new eventdev test > > application > > > > From: Guduri Prathyusha <gprathyu...@caviumnetworks.com> > > > > Add documentation to describe usage of eventdev test application and > > supported command line arguments. > > > > CC: John McNamara <john.mcnam...@intel.com> > > Signed-off-by: Guduri Prathyusha <gprathyu...@caviumnetworks.com> > > Signed-off-by: Jerin Jacob <jerin.ja...@caviumnetworks.com> > > Some comments inline below, but overall good docs; > > > Acked-by: Harry van Haaren <harry.van.haa...@intel.com> > > > > + > > +* ``--plcore <n>`` > > + > > + Set the producer lcore id. > > > There is --plcores (note the added "S") just below. Should standardize to > one. Double check with the app - I had some issues with plcore(s) not working > as expected.
OK. I will remove the --plcore and keep only --plcores > > > + > > +* ``--slcore <n>`` > > + > > + Set the scheduler lcore id.(Valid when eventdev is not > > RTE_EVENT_DEV_CAP_DISTRIBUTED_SCHED capable) > > + > > +* ``--plcores <CORELIST>`` > > + > > + Set the list of cores to be used as producers. > > + > > +* ``--wlcores <CORELIST>`` > > + > > + Set the list of cores to be used as workers. > > + > > +* ``--stlist <type_list>`` > > + > > + Set the scheduled type of each stage where ``type_list`` size > > + determines the number of stages used in the test application. > > + Each type_list member can be one of the following:: > > + > > + P or p : Parallel schedule type > > + O or o : Ordered schedule type > > + A or a : Atomic schedule type > > + > > + Application expects the ``type_list`` in comma separated form > > (i.e. ``--stlist > > o,a,a,a``) > > + > > +* ``--nb_flows <n>`` > > + > > + Set the number of flows to produce. > > + > > +* ``--nb_packets <n>`` > > + > > + Set the number of packets to produce. > > > I think "--nb_pkts" is the correct string, not "packets"? Yes. Thanks for the review > >