04/08/2017 16:38, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 04/08/2017 15:19, Cristian Dumitrescu: > > > +* librte_meter: The API will change to accommodate configuration > > profiles. > > > + Most of the API functions will have an additional opaque parameter. > > > > Why? > > Why opaque parameter? > > If you want to use it with a configuration file, you just have to > > implement a configuration file in your application. > > > > Moreover, I already explained my fear of adding this library in DPDK > > which is really an application-level statistics lib. > > > > Without more explanations, my vote is a nack. > > > > However I remember there was a promise to merge every metrics libs in > > one. > > Thomas, > > Confusion with librte_metrics, which is a totally different library? This is > about librte_meter, nothing to do with stats/metrics.
Yes you're right! Sorry for the confusion. > This librte_meter is doing traffic metering, essentially the computing the > packet color according to the IETF RFCs 2697 (srTCM = Single Rate Three Color > Marker) and 2698 (trTCM = Two Rate Three Color Marker). This is a fundamental > block for pretty much every edge router upstream path. > > You asked me on numerous occasions to be concise, so here is a concise > deprecation notice. I have to say initially I wrote a more laborious one, > then I remembered your advice and cut it down to this version. Thanks for being concise :) > Do you need more details on the motivation? Yes we need to understand why the configuration profiles must be managed by the API instead of separately.
