On Thu, Aug 10, 2017 at 09:34:18AM +0100, Bruce Richardson wrote:
> On Wed, Aug 09, 2017 at 04:24:25PM -0400, Neil Horman wrote:
> > With the new updated requirement for SSE4.2, dpdk no longer supports
> > building on atom machines, as they only support up to SSE3.  Remove
> > the machine definition.
> > 
> > Signed-off-by: Neil Horman <nhor...@tuxdriver.com> CC: Thomas Monjalon
> > <tho...@monjalon.net> --- mk/machine/atm/rte.vars.mk | 58
> > ---------------------------------------------- 1 file changed, 58
> > deletions(-) delete mode 100644 mk/machine/atm/rte.vars.mk
> >
> Yes, good catch, that should have been removed. However, I think the
> commit log should be updated to mention that it no longer supports
> "early" atom machines, or some similar phrase. Atom cores for the last
> number of years do support SSE4, see:
> https://en.wikipedia.org/wiki/Silvermont for example.

I don't really agree with that. If you want to make the claim that only early
atom machines aren't supported, the implication then is that later atom machines
are, and we should keep the machine type, and fix it to build for those targeted
machines (as it stands currently, the compiler errors out on building atom
because it only emits SSE3 instructions and can't inline an SSE4 builtin). I'd
be totally fine with fixing the atom build (which I imageine amounts to passing
-machine=atom -msse4 or something simmilar to the build options.  Once we do
that however, we likely need a runtime check for sse4 support as well, so we
don't just get random SIGILL errors at run time.  


> With that change,
> Acked-by: Bruce Richardson <bruce.richard...@intel.com>

Reply via email to