Hi kevin, > -----Original Message----- > From: Laatz, Kevin > Sent: Monday, September 18, 2017 10:54 PM > To: Yang, Zhiyong <zhiyong.y...@intel.com>; Matej Vido <v...@cesnet.cz>; > Yigit, Ferruh <ferruh.yi...@intel.com>; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > <snip> > > > > -----Original Message----- > > > From: Matej Vido [mailto:v...@cesnet.cz] > > > Sent: Wednesday, September 13, 2017 4:14 PM > > > To: Yigit, Ferruh <ferruh.yi...@intel.com>; Yang, Zhiyong > > > <zhiyong.y...@intel.com>; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v3 0/4] increase port_id range > > > > > > On 11.09.2017 12:23, Ferruh Yigit wrote: > > > > On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > > > >> port_id is currently defined as uint8_t, which is limited to the > > > >> range > > > >> 0 to 255. A larger range is required for vdev scalability. > > > >> > > > >> It is necessary for a redefinition of port_id to extend it from > > > >> 1 bytes to 2 bytes. All ethdev APIs and usages related to port_id > > > >> will be changed at the same time. > > > >> > > > >> Discussion about port_id is the following thread. > > > >> http://www.dpdk.org/dev/patchwork/patch/23208/ > > > >> > > > >> Changes in V2: > > > >> 1. cover more PMDs to increase port_id range. > > > >> 2. cover more examples to increase port_id range. > > > >> 3. add 17.11 release note. > > > >> > > > >> Changes in V3: > > > >> 1. cover mlx4 and mlx5. > > > >> 2. add to increase port_id range in test code. > > > >> 3. The patch "librte_mbuf: modify port initialization value" is > > > >> merged into the patchset. > > > >> > > > >> Zhiyong Yang (4): > > > >> ethdev: increase port_id range > > > >> test: increase port_id range > > > >> examples: increase port_id range > > > >> librte_mbuf: modify port initialization value > > > >> > > <snip> > > Hi Zhiyong, > > Had a look over this patchset. Found that from patch 1/4 to 2/4 test-build > fails, > as expected, please note this in the cover letter. Similarly, from patch 1/4 > to 3/4 > examples fail to build, could also be noted in the cover letter. > > Also, there are some minor comment indentation inconsistencies in > bnx2x_rxtx.h: > bnx2x_rx_queue() > bnx2x_tx_queue() > > In rte_port_ethdev.c , rte_port_ethdev_reader_create() has some modifications > which are unrelated to the patchset. > > Other than that it looks good to me. >
Thanks for your reviews and comments, I will note them and modify the code next version. Thanks Zhiyong > Kevin. >
