Overrunning array schedcore of 128 8-byte elements at element index 128 using index lcore_id. Fixed by correct check index lcoreid condition and change type of lcoreid to unsigned.
Coverity issue: 143459 Fixes: 116819b9ed0d ("examples/performance-thread: add lthread subsystem") Cc: ian.be...@intel.com Cc: sta...@dpdk.org Signed-off-by: Slawomir Mrozowicz <slawomirx.mrozow...@intel.com> --- examples/performance-thread/common/lthread.h | 2 +- examples/performance-thread/common/lthread_sched.c | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/examples/performance-thread/common/lthread.h b/examples/performance-thread/common/lthread.h index 5c2c1a5f0..0cde5919b 100644 --- a/examples/performance-thread/common/lthread.h +++ b/examples/performance-thread/common/lthread.h @@ -87,7 +87,7 @@ int _lthread_desched_sleep(struct lthread *lt); void _lthread_free(struct lthread *lt); -struct lthread_sched *_lthread_sched_get(int lcore_id); +struct lthread_sched *_lthread_sched_get(unsigned int lcore_id); struct lthread_stack *_stack_alloc(void); diff --git a/examples/performance-thread/common/lthread_sched.c b/examples/performance-thread/common/lthread_sched.c index 98291478e..3484387b4 100644 --- a/examples/performance-thread/common/lthread_sched.c +++ b/examples/performance-thread/common/lthread_sched.c @@ -562,11 +562,14 @@ void lthread_run(void) * Return the scheduler for this lcore * */ -struct lthread_sched *_lthread_sched_get(int lcore_id) +struct lthread_sched *_lthread_sched_get(unsigned int lcore_id) { - if (lcore_id > LTHREAD_MAX_LCORES) - return NULL; - return schedcore[lcore_id]; + struct lthread_sched *res = NULL; + + if (lcore_id < LTHREAD_MAX_LCORES) + res = schedcore[lcore_id]; + + return res; } /* -- 2.11.0