08/09/2017 14:57, ilia.kura...@intel.com: > + /* See rte_ethdev_profile.h to find comments on code below. */ > + __rte_eth_profile_rx_init(port_id, dev);
We can find easily where the function is defined. Please replace this comment by something like that: /* Initialize Rx profiling if enabled at compilation time. */ Why not checking an error code for this initialization? If we enable it, we expect the application to abort if the profiling does not work. > --- /dev/null > +++ b/lib/librte_ether/rte_ethdev_profile.h This file is internal so it should not appear in doxygen index. Please remove rte_ prefix from the filename to blacklist it from doxygen point of view. You can apply the same change to the .c file for consistency.
