On Tue, Oct 24, 2017 at 08:45:30AM +0000, Matan Azrad wrote:
> The corrupted code allowed to create internal rule with no any target queue
> in case the rule creation ocured before queues creation.
ocured => occurred
>
> For example, when user calls rte_eth_dev_default_mac_addr_set after probe
> and before dev_configure, mlx4 failis because the RSS queue number was 0.
failis => fails
>
> The fix prevents internal rules creation before queues creation based on
> future creation before traffic start.
>
> Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API")
Since adding MAC addresses before dev_configure() was not taken into account
in the design of the affected function, I suggest appending:
Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules")
> Signed-off-by: Matan Azrad <[email protected]>
Acked-by: Adrien Mazarguil <[email protected]>
Thanks.
--
Adrien Mazarguil
6WIND
