Hi Xueming,
On Thu, Nov 30, 2017 at 01:31:04AM +0800, Xueming Li wrote:
> Signed-off-by: Xueming Li <xuemi...@mellanox.com>
> ---
> app/test-pmd/cmdline_flow.c | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index df16d2a..9402eb7 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -194,6 +194,7 @@ enum index {
> ACTION_RSS,
> ACTION_RSS_QUEUES,
> ACTION_RSS_QUEUE,
> + ACTION_RSS_LEVEL,
> ACTION_PF,
> ACTION_VF,
> ACTION_VF_ORIGINAL,
> @@ -640,6 +641,7 @@ struct parse_action_priv {
>
> static const enum index action_rss[] = {
> ACTION_RSS_QUEUES,
> + ACTION_RSS_LEVEL,
> ACTION_NEXT,
> ZERO,
> };
> @@ -1586,6 +1588,13 @@ static int comp_vc_action_rss_queue(struct context *,
> const struct token *,
> .call = parse_vc_action_rss_queue,
> .comp = comp_vc_action_rss_queue,
> },
> + [ACTION_RSS_LEVEL] = {
> + .name = "level",
> + .help = "rss on tunnel level",
> + .next = NEXT(action_rss, NEXT_ENTRY(UNSIGNED)),
> + .args = ARGS(ARGS_ENTRY(struct rte_flow_action_rss, level)),
> + .call = parse_vc_conf,
> + },
> [ACTION_PF] = {
> .name = "pf",
> .help = "redirect packets to physical device function",
> @@ -1887,6 +1896,7 @@ static int comp_vc_action_rss_queue(struct context *,
> const struct token *,
> sizeof(double));
> if ((uint8_t *)item + sizeof(*item) > data)
> return -1;
> + memset(data, 0, data_size);
> *item = (struct rte_flow_item){
> .type = priv->type,
> };
> @@ -1904,6 +1914,9 @@ static int comp_vc_action_rss_queue(struct context *,
> const struct token *,
> sizeof(double));
> if ((uint8_t *)action + sizeof(*action) > data)
> return -1;
> + memset(data, 0, data_size);
> + if (priv->type == RTE_FLOW_ACTION_TYPE_RSS)
> + ((struct rte_flow_action_rss *)data)->level = -1;
I strongly suggest to let the level set to outer, otherwise most of the
PMD will have to refuse such rule.
> *action = (struct rte_flow_action){
> .type = priv->type,
> };
> @@ -1911,7 +1924,6 @@ static int comp_vc_action_rss_queue(struct context *,
> const struct token *,
> ctx->object = action;
> ctx->objmask = NULL;
> }
> - memset(data, 0, data_size);
> out->args.vc.data = data;
> ctx->objdata = data_size;
> return len;
> --
> 1.8.3.1
>
--
Nélio Laranjeiro
6WIND
