On Mon, 8 Jan 2018 14:51:27 +0100 Maxime Coquelin <maxime.coque...@redhat.com> wrote:
> +static inline bool > +pci_one_device_iommu_support_va(struct rte_pci_device *dev) > +{ > +#if defined(RTE_ARCH_PPC_64) > + return false; > +#elif defined(RTE_ARCH_X86) > + The cleaner way to handle this kind of ifdef is: #ifdef RTE_ARCH_X86 static bool pci_one_device_iommu_support_va(struct rte_pci_device *dev) { .... } #elif defined(RTE_ARCH_PPC_64) static inline bool pci_one_device_iommu_support_va(struct rte_pci_device *dev) { return false; } #endif What about AMD64? Do all ARM processors have IOMMU, I think not.