On 01/09/2018 10:38 PM, Ferruh Yigit wrote:
On 1/8/2018 1:35 PM, Andrew Rybchenko wrote:
Change license from BSD-2-Clause-FreeBSD to BSD-3-Clause.
Bump copyright year.
<...>
@@ -1,28 +1,8 @@
+ SPDX-License-Identifier: BSD-3-Clause
- Copyright (c) 2006-2016 Solarflare Communications Inc.
+ Copyright (c) 2006-2018 Solarflare Communications Inc.
All rights reserved.
Defined syntax has no empty line between SPDX and Copyright line, is that line
intentionally left?
Yes. I've seen examples, but have not found exact requirement to have
no empty line. We have file with 2 copyright holders and it looks strange
in this case without empty line.
And not sure if this cause any problem on scripting license checks in the
future...
Of course this empty line is not that critical and I can remove it if
required.
<...>