On Wednesday 17 January 2018 12:07 AM, Stephen Hemminger wrote:
While reviewing drivers, noticed a lot of unnecessary
duplication of code in drivers for handling the eth_dev link status
information. While consolidating this, it also became obvious that
some drivers behave differently for no good reason.
It also was a good chance to introduce atomic exchange primitives
in EAL because there are other places using cmpset where not
necessary (such as bonding).
Mostly only compile tested only, don't have all of the hardware
available (except ixgbe and virtio) to test.
Note: the eth_dev_link_update function return value is inconsistent
across drivers. Should be changed to be void.
v5
- checkpatch whitespace cleanup
v4
- incorporate review feedback
- rename _rte_linkstatus to rte_linkstatus
- change return value of _rte_linkstatus
- optimize get on 64bit platforms
- change return value of rte_linkstatus_set
v3
- align rte_linkstatus_get with rte_atomic64_read
- virtio use ETH_SPEED_NUM_10G
- add net/
v2
- function names changed
- rebased to current master
[...]
1. "--in-reply-to" is recommended way ([1])
2. Specifically here: there is a v4 already by Ferruh (targeting
maintainers directly, I think) and then another by you. And with
separate threads it is difficult to compare them. Maybe you prefer flat
email threads - it helps people like me who don't.
3. I had put my Ack on v4 by Ferruh, but it seems dpaa2 specific code
has changed from Ferruh's v4 to your v4/v5. Please ignore that Ack. I
will send my acceptance on your v5.
[1] http://dpdk.org/dev
