> -----Original Message----- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Thursday, January 18, 2018 4:35 PM > To: Thomas Monjalon <tho...@monjalon.net>; Gaetan Rivet > <gaetan.ri...@6wind.com>; Wu, Jingjing <jingjing...@intel.com> > Cc: dev@dpdk.org; Neil Horman <nhor...@tuxdriver.com>; Richardson, Bruce > <bruce.richard...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; sta...@dpdk.org > Subject: [PATCH v3 1/7] ethdev: fix port data reset timing > > rte_eth_dev_data structure is allocated per ethdev port and can be > used to get a data of the port internally. > > rte_eth_dev_attach_secondary tries to find the port identifier using > rte_eth_dev_data name field comparison and may get an identifier of > invalid port in case of this port was released by the primary process > because the port release API doesn't reset the port data. > > So, it will be better to reset the port data in release time instead of > allocation time. > > Move the port data reset to the port release API. > > Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple process > model") > Cc: sta...@dpdk.org > > Signed-off-by: Matan Azrad <ma...@mellanox.com> > --- > lib/librte_ether/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 7044159..156231c 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -204,7 +204,6 @@ struct rte_eth_dev * > return NULL; > } > > - memset(&rte_eth_dev_data[port_id], 0, sizeof(struct rte_eth_dev_data)); > eth_dev = eth_dev_get(port_id); > snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), "%s", name); > eth_dev->data->port_id = port_id; > @@ -252,6 +251,7 @@ struct rte_eth_dev * > if (eth_dev == NULL) > return -EINVAL; > > + memset(eth_dev->data, 0, sizeof(struct rte_eth_dev_data)); > eth_dev->state = RTE_ETH_DEV_UNUSED; > > _rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_DESTROY, NULL); > -- > 1.8.3.1
Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
