Hi Shahaf,
On Tue, Jan 23, 2018 at 07:08:21PM +0200, Shahaf Shuler wrote:
> Memory registration can fail, add the proper assert for such scenario
> for it at least to be visible in debug mode.
>
> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>
> Signed-off-by: Xueming Li <xuemi...@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h
> index 79cdfc793..2934f9fb3 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.h
> +++ b/drivers/net/mlx5/mlx5_rxtx.h
> @@ -589,6 +589,10 @@ mlx5_tx_mb2mr(struct mlx5_txq_data *txq, struct rte_mbuf
> *mb)
> if (mr) {
> rte_atomic32_inc(&mr->refcnt);
> return mr->lkey;
> + } else {
> + WARN("Failed to register mempool 0x%p(%s)",
> + (void *)mp, mp->name);
> + assert(mr != NULL);
This assert seems wrong.
Why this assert, you don't trust the CPU to verify the pointer is NULL?
> }
> return (uint32_t)-1;
> }
> --
> 2.12.0
Regards,
--
Nélio Laranjeiro
6WIND
