On Wed, 24 Jan 2018 19:08:02 +0100 Thomas Monjalon <tho...@monjalon.net> wrote:
> 24/01/2018 16:39, Stephen Hemminger: > > On Wed, 24 Jan 2018 14:12:13 +0000 > > Ophir Munk <ophi...@mellanox.com> wrote: > > > --- a/drivers/net/vdev_netvsc/Makefile > > > +++ b/drivers/net/vdev_netvsc/Makefile > > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > > > # Additional compilation flags. > > > CFLAGS += -O3 > > > CFLAGS += -g > > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra > > > +CFLAGS += -Wall -Wextra > > > CFLAGS += -D_XOPEN_SOURCE=600 > > > CFLAGS += -D_BSD_SOURCE > > > CFLAGS += -D_DEFAULT_SOURCE > > > > Why did this driver not use $(WERROR) like rest of DPDK drivers. > > It can be a separate patch. > Matan? I meant that you should use: CFLAGS += $(WERROR_FLAGS) instead of CFLAGS += -Wall -Wextra in this patch. Also, do you really need all the other CFLAGS? Why? This driver has no reason to be a special case different from what is done in virtio, vmxnet3, ixgbe, e1000, ...
