Hi Pavan, Your patch was breaking the design of the best_mempool_ops and the whole purpose of selection was getting lost. I guess you were trying to fix test_mempool. I have sent another patch, which fixes that and start using the best mempool ops API instead of default mempool ops API.
Regards, Hemant > -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Friday, February 02, 2018 1:17 AM > To: olivier.m...@6wind.com; pbhagavat...@caviumnetworks.com > Cc: tho...@monjalon.net; dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" > > This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2. > --- > lib/librte_eal/bsdapp/eal/eal.c | 3 --- > lib/librte_eal/linuxapp/eal/eal.c | 3 --- > 2 files changed, 6 deletions(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c > index 1622a41..b612af0 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > @@ -86,9 +86,6 @@ int rte_cycles_vmware_tsc_map; const char * > rte_eal_mbuf_default_mempool_ops(void) > { > - if (internal_config.user_mbuf_pool_ops_name == NULL) > - return RTE_MBUF_DEFAULT_MEMPOOL_OPS; > - > return internal_config.user_mbuf_pool_ops_name; > } > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c > b/lib/librte_eal/linuxapp/eal/eal.c > index 451fdaf..21024b4 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -96,9 +96,6 @@ int rte_cycles_vmware_tsc_map; const char * > rte_eal_mbuf_default_mempool_ops(void) > { > - if (internal_config.user_mbuf_pool_ops_name == NULL) > - return RTE_MBUF_DEFAULT_MEMPOOL_OPS; > - > return internal_config.user_mbuf_pool_ops_name; > } > > -- > 2.7.4