On Thu, Mar 08, 2018 at 10:46:46AM +0000, Burakov, Anatoly wrote: > On 08-Mar-18 10:18 AM, Pavan Nikhilesh wrote: > > Hi Anatoly, > > > > I am trying to verify this patchset and have encountered few issues. > > > > Few -Werror=maybe-uninitialized errors in eal_memalloc.c/eal_memory.c/ > > eal_common_memzone.c files. > > Thanks for the heads up, i'll fix those in the next revision. Out of > curiousity, which compiler version are you using?
I'm using gcc 5.3.0. > > > > > diff --git a/lib/librte_eal/common/eal_common_memzone.c > > b/lib/librte_eal/common/eal_common_memzone.c > > index a7cfdaf03..ad4413507 100644 > > --- a/lib/librte_eal/common/eal_common_memzone.c > > +++ b/lib/librte_eal/common/eal_common_memzone.c > > @@ -321,7 +321,7 @@ rte_memzone_free(const struct rte_memzone *mz) > > struct rte_fbarray *arr; > > struct rte_memzone *found_mz; > > int ret = 0; > > - void *addr; > > + void *addr = NULL; > > unsigned idx; > > > > if (mz == NULL) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > index 1008faed6..32b0d5133 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c > > @@ -570,7 +570,7 @@ eal_memalloc_alloc_page_bulk(struct rte_memseg **ms, > > int n, > > unsigned int msl_idx; > > int cur_idx, start_idx, end_idx, i, j, ret = -1; > > #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES > > - bool have_numa; > > + bool have_numa = false; > > int oldpolicy; > > struct bitmask *oldmask = numa_allocate_nodemask(); > > #endif > > diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c > > b/lib/librte_eal/linuxapp/eal/eal_memory.c > > index f74291fb6..d37b4a59b 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal_memory.c > > +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c > > @@ -1386,9 +1386,9 @@ eal_legacy_hugepage_attach(void) > > struct rte_mem_config *mcfg = > > rte_eal_get_configuration()->mem_config; > > struct hugepage_file *hp = NULL; > > unsigned int num_hp = 0; > > - unsigned int i; > > + unsigned int i = 0; > > int ms_idx, msl_idx; > > - unsigned int cur_seg, max_seg; > > + unsigned int cur_seg, max_seg = 0; > > off_t size = 0; > > int fd, fd_hugepage = -1; > > > > > > > > @Hemanth > > Also, this patchset breaks dpaa/dpaa2 bus drivers (they rely on > > `rte_eal_get_physmem_layout` that is depricated > > http://dpdk.org/dev/patchwork/patch/34002/) > > So, generic arm64 linuxapp build is broken. > > Should the deprecation notice have been accompanied with marking that > function as __rte_deprecated? Yup that's the general sequence. > > > > > Regards, > > Pavan. > > > > On Wed, Mar 07, 2018 at 04:56:28PM +0000, Anatoly Burakov wrote: > > > This patchset introduces dynamic memory allocation for DPDK (aka memory > > > hotplug). Based upon RFC submitted in December [1]. > > > > > > Dependencies (to be applied in specified order): > > > - IPC bugfixes patchset [2] > > > - IPC improvements patchset [3] > > > - IPC asynchronous request API patch [4] > > > - Function to return number of sockets [5] > > > > > <snip> > > -- > > > 2.7.4 > > > > > -- > Thanks, > Anatoly
