On 3/13/2018 9:24 AM, Van Haaren, Harry wrote:
>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Monday, March 12, 2018 5:53 PM
>> To: Lu, Wenzhuo <wenzhuo...@intel.com>; Wu, Jingjing <jingjing...@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yi...@intel.com>; Shahaf Shuler
>> <shah...@mellanox.com>; Yongseok Koh <ys...@mellanox.com>
>> Subject: [dpdk-dev] [PATCH v3] app/testpmd: print Rx/Tx offload values
>> Which per port offloads are enabled is not clear. Printing offloads
>> values at forwarding start.
>> CRC strip offload value was printed in more verbose manner, it is
>> removed since Rx/Tx offload values covers it and printing only CRC one
>> can cause confusion.
>> Hexadecimal offloads values are not very user friendly but preferred to
>> not create to much noise during forwarding start.
> Hmmm - I'm thinking is there a better method to reduce verbosity, but keep
> user friendliness?
> Can the dynamic logs be used? By default, just print the hex mask, but with
> --log-level="pmd.net.*.offload_flags" we print the list, itemized?
> crc strip .......... 1
> vlan strip ......... 1
> udp checksum ....... 0

As Yongseok mentioned 'show port cap all' prints the offload capabilities in a
more user friendly way [1] [2]. This patch adds a summary config log after
"start" command, I think it is good to keep it brief.

Related to the "pmd.net.*.offload_flags" suggestion, we are currently using log
types to select components, it can be interesting to use feature based log
types, ethdev may register them and PMDs can use it.

************ Port 0 supported offload features: ************
VLAN stripped:                 off
Double VLANs stripped:         off
RX IPv4 checksum:              off
RX UDP checksum:               off
RX TCP checksum:               off
RX Outer IPv4 checksum:               off
VLAN insert:                   off
Double VLANs insert:           off
TX IPv4 checksum:              off
TX UDP checksum:               off
TX TCP checksum:               off
TX SCTP checksum:              off
TX Outer IPv4 checksum:        off
TX TCP segmentation:           off
TSO for VXLAN tunnel packet:   off
TSO for GRE tunnel packet:     off
TSO for IPIP tunnel packet:    off
TSO for GENEVE tunnel packet:  off

This command needs a volunteer to add missing offloading types.

> I'm not sure what the exact string should be - testpmd specific or DPDK wide 
> at the PMD level?

Reply via email to