Comments inline. On the whole looks good to me.
On 12/03/2018 04:17, Zijie Pan wrote:
[..]
Signed-off-by: Zijie Pan <[email protected]>
---
doc/guides/sample_app_ug/ethtool.rst | 2 ++
examples/ethtool/ethtool-app/ethapp.c | 61 +++++++++++++++++++++++++++++++++
examples/ethtool/lib/rte_ethtool.c | 30 ++++++++++++++++
examples/ethtool/lib/rte_ethtool.h | 34 ++++++++++++++++++
4 files changed, 127 insertions(+)
Reviewed-by: Remy Horton <[email protected]>
cmdline_parse_token_string_t pcmd_eeprom_token_cmd =
TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd, "eeprom");
+cmdline_parse_token_string_t pcmd_module_eeprom_token_cmd =
+ TOKEN_STRING_INITIALIZER(struct pcmd_intstr_params, cmd,
"module-eeprom");
Checkpatch: 80 character limit.
+ info_eeprom.len = module_info[1];
+ info_eeprom.offset = 0;
+ stat = rte_ethtool_get_module_eeprom(params->port,
+ &info_eeprom, bytes_eeprom);
+ if (stat != 0 || module_info[1] <= 0) {
This supposed to be module_info[1] rather than info_eeprom.len ?
