Hi Thomas, > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, March 22, 2018 4:52 AM > To: Wang, Xiao W <xiao.w.w...@intel.com>; Xu, Rosen <rosen...@intel.com> > Cc: dev@dpdk.org; maxime.coque...@redhat.com; y...@fridaylinux.org; Wang, > Zhihong <zhihong.w...@intel.com>; Bie, Tiwei <tiwei....@intel.com>; Chen, > Junjie J <junjie.j.c...@intel.com>; Daly, Dan <dan.d...@intel.com>; Liang, > Cunming <cunming.li...@intel.com>; Burakov, Anatoly > <anatoly.bura...@intel.com>; gaetan.ri...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/ifcvf: add ifcvf driver > > 21/03/2018 14:21, Xiao Wang: > > ifcvf driver uses vdev as a control domain to manage ifc VFs that belong > > to it. It registers vDPA device ops to vhost lib to enable these VFs to be > > used as vhost data path accelerator. > > Not everybody work at Intel. > Please explain what means ifcvf and what is a control domain.
OK, and I will add a document. > > > Live migration feature is supported by ifc VF and this driver enables > > it based on vhost lib. > > > > Because vDPA driver needs to set up MSI-X vector to interrupt the guest, > > only vfio-pci is supported currently. > > > > Signed-off-by: Xiao Wang <xiao.w.w...@intel.com> > > Signed-off-by: Rosen Xu <rosen...@intel.com> > > --- > > v2: > > - Rebase on Zhihong's vDPA v3 patch set. > > --- > > config/common_base | 6 + > > config/common_linuxapp | 1 + > > drivers/net/Makefile | 1 + > > drivers/net/ifcvf/Makefile | 40 + > > drivers/net/ifcvf/base/ifcvf.c | 329 ++++++++ > > drivers/net/ifcvf/base/ifcvf.h | 156 ++++ > > drivers/net/ifcvf/base/ifcvf_osdep.h | 52 ++ > > drivers/net/ifcvf/ifcvf_ethdev.c | 1240 > +++++++++++++++++++++++++++++++ > > drivers/net/ifcvf/rte_ifcvf_version.map | 4 + > > mk/rte.app.mk | 1 + > > This feature needs to be explained and documented. > It will be helpful to understand the mechanism and to have a good review. > Please do not merge it until there is a good documentation. > Will add a doc with more details. BRs, Xiao