> -----Original Message----- > From: Zhoujian (jay) [mailto:[email protected]] > Sent: Friday, March 30, 2018 3:44 AM > To: De Lara Guarch, Pablo <[email protected]>; > [email protected] > Cc: Zhang, Roy Fan <[email protected]>; [email protected]; > Gonglei (Arei) <[email protected]>; Zeng, Xin > <[email protected]>; Huangweidong (C) <[email protected]>; > wangxin (U) <[email protected]>; longpeng > <[email protected]> > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session > structure > > > > > -----Original Message----- > > From: De Lara Guarch, Pablo [mailto:[email protected]] > > Sent: Friday, March 30, 2018 6:12 AM > > To: Zhoujian (jay) <[email protected]>; [email protected] > > Cc: Zhang, Roy Fan <[email protected]>; [email protected]; > > Gonglei > > (Arei) <[email protected]>; Zeng, Xin <[email protected]>; > > Huangweidong (C) <[email protected]>; wangxin (U) > > <[email protected]>; longpeng <[email protected]> > > Subject: RE: [PATCH v3 2/7] crpyto/virtio: add crypto related session > > structure > > > > > > > > > -----Original Message----- > > > From: Jay Zhou [mailto:[email protected]] > > > Sent: Sunday, March 25, 2018 9:34 AM > > > To: [email protected] > > > Cc: De Lara Guarch, Pablo <[email protected]>; Zhang, > > > Roy Fan <[email protected]>; [email protected]; > > > [email protected]; Zeng, Xin <[email protected]>; > > > [email protected]; [email protected]; > > > [email protected]; [email protected] > > > Subject: [PATCH v3 2/7] crpyto/virtio: add crypto related session > > > structure > > > > Typo in title. > > Will fix. > > > > > > > > > This structure will be used in the following patches, especially at > > > creating and destroying crypto sessions. > > > > > > Signed-off-by: Jay Zhou <[email protected]> > > > --- > > > drivers/crypto/virtio/virtio_crypto_algs.h | 27 > > > +++++++++++++++++++++++++++ > > > 1 file changed, 27 insertions(+) > > > create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h > > > > > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.h > > > b/drivers/crypto/virtio/virtio_crypto_algs.h > > > new file mode 100644 > > > index 0000000..5f1e9df > > > --- /dev/null > > > +++ b/drivers/crypto/virtio/virtio_crypto_algs.h > > > @@ -0,0 +1,27 @@ > > > +/* SPDX-License-Identifier: BSD-3-Clause > > > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD. > > > + */ > > > + > > > +#ifndef _VIRTIO_CRYPTO_ALGS_H_ > > > +#define _VIRTIO_CRYPTO_ALGS_H_ > > > + > > > +#include <rte_memory.h> > > > +#include <linux/virtio_crypto.h> > > > + > > > +struct virtio_crypto_session { > > > + uint64_t session_id; > > > > Probably a uint32_t here is enough. > > Consider the type of session_id in the struct virtio_crypto_op_header of > linux kernel and QEMU side is uint64_t, could we just keep it as uint64_t > for consistency?
Fair enough. Pablo > > Regards, > Jay
