On Tue, Apr 03, 2018 at 10:26:15AM +0200, Olivier Matz wrote: > Hi, > > On Mon, Apr 02, 2018 at 11:50:03AM -0700, Yongseok Koh wrote: > > When attaching a mbuf, indirect mbuf has to point to start of buffer of > > direct mbuf. By adding buf_off field to rte_mbuf, this becomes more > > flexible. Indirect mbuf can point to any part of direct mbuf by calling > > rte_pktmbuf_attach_at(). > > > > Possible use-cases could be: > > - If a packet has multiple layers of encapsulation, multiple indirect > > buffers can reference different layers of the encapsulated packet. > > - A large direct mbuf can even contain multiple packets in series and > > each packet can be referenced by multiple mbuf indirections. > > > > Signed-off-by: Yongseok Koh <ys...@mellanox.com> > > I think the current API is already able to do what you want. > > 1/ Here is a mbuf m with its data > > off > <--> > len > +----+ <----------> > | | > +-|----v----------------------+ > | | -----------------------| > m | buf | XXXXXXXXXXX || > | -----------------------| > +-----------------------------+ > > > 2/ clone m: > > c = rte_pktmbuf_alloc(pool); > rte_pktmbuf_attach(c, m); > > Note that c has its own offset and length fields. > > > off > <--> > len > +----+ <----------> > | | > +-|----v----------------------+ > | | -----------------------| > m | buf | XXXXXXXXXXX || > | -----------------------| > +------^----------------------+ > | > +----+ > indirect | > +-|---------------------------+ > | | -----------------------| > c | buf | || > | -----------------------| > +-----------------------------+ > > off len > <--><----------> > > > 3/ remove some data from c without changing m > > rte_pktmbuf_adj(c, 10) // at head > rte_pktmbuf_trim(c, 10) // at tail > > > Please let me know if it fits your needs.
No, it doesn't. Trimming head and tail with the current APIs removes data and make the space available. Adjusting packet head means giving more headroom, not shifting the buffer itself. If m has two indirect mbufs (c1 and c2) and those are pointing to difference offsets in m, rte_pktmbuf_adj(c1, 10); rte_pktmbuf_adj(c2, 20); then the owner of c2 regard the first (off+20)B as available headroom. If it wants to attach outer header, it will overwrite the headroom even though the owner of c1 is still accessing it. Instead, another mbuf (h1) for the outer header should be linked by h1->next = c2. If c1 and c2 are attached with shifting buffer address by adjusting buf_off, which actually shrink the headroom, this case can be properly handled. And another use-case (this is my actual use-case) is to make a large mbuf have multiple packets in series. AFAIK, this will also be helpful for some FPGA NICs because it transfers multiple packets to a single large buffer to reduce PCIe overhead for small packet traffic like the Multi-Packet Rx of mlx5 does. Otherwise, packets should be memcpy'd to regular mbufs one by one instead of indirect referencing. Does this make sense? Thanks, Yongseok
