> -----Original Message-----
> From: Carrillo, Erik G
> Sent: Tuesday, April 3, 2018 3:21 PM
> To: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>;
> jerin.ja...@caviumnetworks.com; santosh.shu...@caviumnetworks.com
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer
> adapter as a producer
> 
> Hi Pavan,
> 
> One comment in-line:
> 
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com]
> > Sent: Tuesday, April 3, 2018 11:02 AM
> > To: jerin.ja...@caviumnetworks.com;
> > santosh.shu...@caviumnetworks.com; Carrillo, Erik G
> > <erik.g.carri...@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh
> <pbhagavat...@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v2 1/4] app/eventdev: add event timer
> > adapter as a producer
> >
> > Add event timer adapter as producer option that can be selected by
> > passing - -prod_type_timerdev.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavat...@caviumnetworks.com>
> > ---
> 
> <...snipped...>
> 
> > diff --git a/app/test-eventdev/evt_options.h b/app/test-
> > eventdev/evt_options.h index 46d122229..37debae84 100644
> > --- a/app/test-eventdev/evt_options.h
> > +++ b/app/test-eventdev/evt_options.h
> > @@ -31,12 +31,14 @@
> >  #define EVT_FWD_LATENCY          ("fwd_latency")
> >  #define EVT_QUEUE_PRIORITY       ("queue_priority")
> >  #define EVT_PROD_ETHDEV          ("prod_type_ethdev")
> > +#define EVT_PROD_TIMERDEV        ("prod_type_timerdev")
> >  #define EVT_HELP                 ("help")
> >
> >  enum evt_prod_type {
> >     EVT_PROD_TYPE_NONE,
> >     EVT_PROD_TYPE_SYNT,          /* Producer type Synthetic i.e. CPU. */
> >     EVT_PROD_TYPE_ETH_RX_ADPTR,  /* Producer type Eth Rx Adapter.
> > */
> > +   EVT_PROD_TYPE_EVENT_TIMER_ADPTR,  /* Producer type Eth Rx
> > Adapter. */
> 
> Comment didn't get updated here.
> 

With that edit:

Acked-by: Erik Gabriel Carrillo <erik.g.carri...@intel.com>

Reply via email to