On Sat, Apr 07, 2018 at 12:51:40PM +0300, Andrew Rybchenko wrote: > On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > > This patch adds the missing action counterpart to the PHY_PORT pattern > > item, that is, the ability to directly inject matching traffic into a > > physical port of the underlying device. > > Does it mean that if it is applied on ingress (incoming packet from network) > it will simply send packets back to network (specified physical port)?
Precisely. > And if it is applied on egress (outgoing from device to network) it will > be directed to possibly different physical port and sent to network. Right, note it gives applications the ability to express that wish, the fact PMDs support it is another matter :) In any case, this action is added for API completeness but should be rarely necessary since we chose to go with port representors. Port representors will expose valid DPDK port IDs, therefore applications will simply have to create ingress/egress flow rules on the right DPDK port targeting different port IDs through the PORT_ID action. > > It breaks ABI compatibility for the following public functions: > > > > - rte_flow_copy() > > - rte_flow_create() > > - rte_flow_query() > > - rte_flow_validate() > > > > Signed-off-by: Adrien Mazarguil <adrien.mazarg...@6wind.com> > > Cc: "Zhang, Qi Z" <qi.z.zh...@intel.com> > > --- > > app/test-pmd/cmdline_flow.c | 35 ++++++++++++++++++++++++ > > app/test-pmd/config.c | 1 + > > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++++++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 ++++ > > lib/librte_ether/rte_flow.c | 1 + > > lib/librte_ether/rte_flow.h | 22 +++++++++++++++ > > 6 files changed, 84 insertions(+) > > <...> -- Adrien Mazarguil 6WIND