On Mon, 9 Apr 2018 13:49:48 +0100
Jasvinder Singh <jasvinder.si...@intel.com> wrote:
> Fix build error with gcc 8.0 due to cast between function types.
> Fixes: 5a80bf0ae613 ("table: add cuckoo hash")
>
> Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
> ---
> lib/librte_table/rte_table_hash_cuckoo.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_table/rte_table_hash_cuckoo.c
> b/lib/librte_table/rte_table_hash_cuckoo.c
> index dcb4fe9..f7eae27 100644
> --- a/lib/librte_table/rte_table_hash_cuckoo.c
> +++ b/lib/librte_table/rte_table_hash_cuckoo.c
> @@ -103,11 +103,13 @@ rte_table_hash_cuckoo_create(void *params,
> return NULL;
> }
>
> + void *hash_func = p->f_hash;
> +
> /* Create cuckoo hash table */
> struct rte_hash_parameters hash_cuckoo_params = {
> .entries = p->n_keys,
> .key_len = p->key_size,
> - .hash_func = (rte_hash_function)(p->f_hash),
> + .hash_func = (rte_hash_function) hash_func,
> .hash_func_init_val = p->seed,
> .socket_id = socket_id,
> .name = p->name
This is just tricking the compiler into not complaining.
I would really rather see the two hash functions made the same.
