[dpdk-dev] [PATCH v5 09/70] eal: replace panics with error messages in malloc

[Anatoly Burakov]

We shouldn't ever panic in system libraries, let alone in
such core ones as EAL, so replace all panic messages with
error messages.

Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Tested-by: Santosh Shukla <santosh.shu...@caviumnetworks.com>
Tested-by: Hemant Agrawal <hemant.agra...@nxp.com>
---

Notes:
    v4: clarified commit message

 lib/librte_eal/common/rte_malloc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/librte_eal/common/rte_malloc.c 
b/lib/librte_eal/common/rte_malloc.c
index f11a822..2cda48e 100644
--- a/lib/librte_eal/common/rte_malloc.c
+++ b/lib/librte_eal/common/rte_malloc.c
@@ -30,7 +30,7 @@ void rte_free(void *addr)
 {
        if (addr == NULL) return;
        if (malloc_heap_free(malloc_elem_from_data(addr)) < 0)
-               rte_panic("Fatal error: Invalid memory\n");
+               RTE_LOG(ERR, EAL, "Error: Invalid memory\n");
 }
 
 /*
@@ -134,8 +134,10 @@ rte_realloc(void *ptr, size_t size, unsigned align)
                return rte_malloc(NULL, size, align);
 
        struct malloc_elem *elem = malloc_elem_from_data(ptr);
-       if (elem == NULL)
-               rte_panic("Fatal error: memory corruption detected\n");
+       if (elem == NULL) {
+               RTE_LOG(ERR, EAL, "Error: memory corruption detected\n");
+               return NULL;
+       }
 
        size = RTE_CACHE_LINE_ROUNDUP(size), align = 
RTE_CACHE_LINE_ROUNDUP(align);
        /* check alignment matches first, and if ok, see if we can resize block 
*/
-- 
2.7.4