On 4/10/2018 9:29 AM, Thomas Monjalon wrote:
> 10/04/2018 10:20, Nélio Laranjeiro:
>> On Tue, Apr 10, 2018 at 09:16:31AM +0300, Shahaf Shuler wrote:
>>> When application works with LSC interrupts the ethdev layer skips
>>> the PMD callback and update according to the link status exists on
>>> device data. It is because it assumes the link status on the device data
>>> is the correct one since any link change is processed by the application.
>>>
>>> As multiple PMDs install the link status interrupt handler only on port
>>> start and uninstall it on port stop, the link status may be incorrect in
>>> case the query is called after port stop or before port start.
>>
>> It seems also logical to not process interrupts from stopped device,
>> for them accessing to the link status should always end by calling the
>> devop function.
>>
>> This patch is the result of discussion on thread [1].
>>
>>> Fixing the query implementation to use the PMD callback for such cases.
>>>
>>> Fixes: b77d21cc2364 ("ethdev: add link status get/set helper functions")
>>> Cc: sta...@dpdk.org
>>> Cc: step...@networkplumber.org
>>> Cc: nelio.laranje...@6wind.com
>>
>> Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
>>
>>> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>
>
> Looks OK
>
> Acked-by: Thomas Monjalon <tho...@monjalon.net>
Applied to dpdk-next-net/master, thanks.
