On 04/10/2018 07:36 PM, Adrien Mazarguil wrote:
VLAN TCI is a 16-bit field broken down as PCP (3b), DEI (1b) and VID (12b).
The default mask used by PMDs for the VLAN pattern when one isn't provided
by the application comprises the entire TCI, which is problematic because
most devices only support VID matching.
This forces applications to always provide a mask limited to the VID part
in order to successfully apply a flow rule with a VLAN pattern item.
Moreover, applications rarely want to match PCP and DEI intentionally.
Given the above and since VID is what is commonly referred to when talking
about VLAN, this commit excludes PCP and DEI from the default mask.
Signed-off-by: Adrien Mazarguil <[email protected]>
Cc: Ferruh Yigit <[email protected]>
Cc: Thomas Monjalon <[email protected]>
Cc: Wenzhuo Lu <[email protected]>
Cc: Jingjing Wu <[email protected]>
Cc: Ajit Khaparde <[email protected]>
Cc: Somnath Kotur <[email protected]>
Cc: John Daley <[email protected]>
Cc: Hyong Youb Kim <[email protected]>
Cc: Beilei Xing <[email protected]>
Cc: Qi Zhang <[email protected]>
Cc: Konstantin Ananyev <[email protected]>
Cc: Nelio Laranjeiro <[email protected]>
Cc: Yongseok Koh <[email protected]>
Cc: Tomasz Duszynski <[email protected]>
Cc: Dmitri Epshtein <[email protected]>
Cc: Natalie Samsonov <[email protected]>
Cc: Jianbo Liu <[email protected]>
Cc: Andrew Rybchenko <[email protected]>
Cc: Pascal Mazon <[email protected]>
---
v3 changes:
These changes were previously mistakenly made part of the previous patch
("ethdev: refine TPID handling in flow API") from which they were split
following Andrew's rightful comment [1].
[1] http://dpdk.org/ml/archives/dev/2018-April/095870.html
---
doc/guides/prog_guide/rte_flow.rst | 2 +-
lib/librte_ether/rte_flow.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Andrew Rybchenko <[email protected]>
