On Wed, Apr 11, 2018 at 8:21 PM, Zhang, Qi Z <qi.z.zh...@intel.com> wrote: > Hi tonghao: > >> -----Original Message----- >> From: Tonghao Zhang [mailto:xiangxia.m....@gmail.com] >> Sent: Monday, April 9, 2018 8:53 AM >> To: Zhang, Qi Z <qi.z.zh...@intel.com> >> Cc: Xing, Beilei <beilei.x...@intel.com>; Dai, Wei <wei....@intel.com>; >> Zhang, >> Helin <helin.zh...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>; >> dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. >> >> On Wed, Apr 4, 2018 at 10:48 AM, Zhang, Qi Z <qi.z.zh...@intel.com> wrote: >> > >> > >> >> -----Original Message----- >> >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tonghao Zhang >> >> Sent: Thursday, March 8, 2018 6:57 PM >> >> To: Xing, Beilei <beilei.x...@intel.com>; Dai, Wei >> >> <wei....@intel.com>; Zhang, Helin <helin.zh...@intel.com>; Lu, >> >> Wenzhuo <wenzhuo...@intel.com> >> >> Cc: dev@dpdk.org; Tonghao Zhang <xiangxia.m....@gmail.com> >> >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. >> >> >> >> ping .... >> >> >> >> On Mon, Feb 5, 2018 at 8:51 AM, <xiangxia.m....@gmail.com> wrote: >> >> > From: Tonghao Zhang <xiangxia.m....@gmail.com> >> >> > >> >> > The patches in the patchset have no dependency. But all of them is >> >> > about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration >> >> > for ixgbe and ixgbevf, the user and developer can configure it for >> >> > their platform. Other patches refine the ixgbe or ixgbevf. >> >> > >> >> > v2 --> v3: >> >> > remove the patch: http://dpdk.org/dev/patchwork/patch/33698 >> >> > >> >> > Tonghao Zhang (5): >> >> > net/ixgbevf: set the inter-interrupt interval for EITR. >> >> > net/ixgbe: set the ITR via configuration. >> >> > net/ixgbe: write disable to ITR counter. >> >> > net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance. >> >> > net/ixgbe: remove the unnecessary call rte_intr_enable. >> >> > >> >> > config/common_base | 2 + >> >> > drivers/net/ixgbe/ixgbe_ethdev.c | 79 >> >> > +++++++++++++++++++++++----------------- >> >> > drivers/net/ixgbe/ixgbe_ethdev.h | 12 ++++++ >> >> > drivers/net/ixgbe/ixgbe_rxtx.c | 3 +- >> >> > 4 files changed, 61 insertions(+), 35 deletions(-) >> >> > >> >> > -- >> >> > 1.8.3.1 >> >> > >> > >> > Review-by: Qi Zhang <qi.z.zh...@intel.com> >> > >> > Minor typo error in patch1 need to be fixed. >> Should I sent v4 ? > > One more capture on patch 5, > https://dpdk.org/dev/patchwork/patch/36433/ > Remove rte_intr_enable in interrupt handler may not work with legacy > interrupt mode which ixgbe supposed to support. Remove it, and thanks for your review.
> It's better to so some test on that mode if you want patch 5 be applied, > or we can just remove patch 5 and I'd like to ack patch 1-4, what do you > think? > > Regards > Qi > >
