Hi Abhinandan, > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Wednesday, April 4, 2018 7:34 AM > To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; Doherty, Declan > <declan.dohe...@intel.com>; jerin.ja...@caviumnetworks.com; > hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender <narender.vang...@intel.com>; Gujjar, Abhinandan S > <abhinandan.guj...@intel.com>; Rao, Nikhil <nikhil....@intel.com> > Subject: [dpdk-dev,v1,2/3] cryptodev: add support to set session private data >
Generally, it is better to directly use "support" in the title, and not "add support". Maybe better write: "cryptodev: support session private data setting" ... > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > b/lib/librte_cryptodev/rte_cryptodev_version.map > index eb47308..c3a3fda 100644 > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > @@ -85,3 +85,10 @@ DPDK_17.11 { > rte_cryptodev_pmd_parse_input_args; > > } DPDK_17.08; > + > +DPDK_18.05 { > + global: > + > + rte_cryptodev_sym_session_set_private_data; > + rte_cryptodev_sym_session_get_private_data; This list has to be in alphabetical order. Rest looks good to me, so: Acked-by: Pablo de Lara <pablo.de.lara.gua...@intel.com> Lastly, since Akhil has acked the patch, you can add his and my ack in v2. Thanks, Pablo