13/04/2018 19:31, Ferruh Yigit: > On 3/28/2018 9:57 AM, Wei Dai wrote: > > This patch check if a requested offloading > > is supported in the device capability. > > A per port offloading feature should be enabled or > > disabled at same time in both rte_eth_dev_configure( ) > > and rte_eth_rx_queue_setup( )/rte_eth_tx_queue_setup( ). > > This patch check if a per port offloading flag has > > same configuration in rte_eth_dev_configure( ) and > > rte_eth_rx_queue_setup( )/rte_eth_tx_queue_setup( ). > > This patch can make such checking in a common way in > > rte_ethdev layer to avoid same checking in underlying PMD. > > I think it is good idea to move common check to the abstraction layer as much > as > possible. > > But for this case we are targeting an API change in rc2, I believe better wait > that API change for this update.
I think Wei could implement some filtering of offload flags: If an offload is already enabled at port level, we can filter out them when enabling again at queue level. By removing such repetition in ethdev, before calling the PMD op, the PMD does not need to bother for offloads enabled twice.