Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo [mailto:[email protected]] > Sent: Sunday, April 15, 2018 8:09 PM > To: Zhoujian (jay) <[email protected]>; [email protected] > Cc: Zhang, Roy Fan <[email protected]>; [email protected]; Gonglei > (Arei) <[email protected]>; Zeng, Xin <[email protected]>; > Huangweidong (C) <[email protected]>; wangxin (U) > <[email protected]>; longpeng <[email protected]> > Subject: RE: [PATCH v9 09/11] crypto/virtio: build with meson > > Hi Jay, > > > -----Original Message----- > > From: Jay Zhou [mailto:[email protected]] > > Sent: Sunday, April 15, 2018 9:51 AM > > To: [email protected] > > Cc: De Lara Guarch, Pablo <[email protected]>; Zhang, Roy > > Fan <[email protected]>; [email protected]; > > [email protected]; Zeng, Xin <[email protected]>; > > [email protected]; [email protected]; > > [email protected]; [email protected] > > Subject: [PATCH v9 09/11] crypto/virtio: build with meson > > > > Signed-off-by: Jay Zhou <[email protected]> > > Reviewed-by: Fan Zhang <[email protected]> > > Acked-by: Fan Zhang <[email protected]> > > --- > > drivers/crypto/meson.build | 2 +- > > drivers/crypto/virtio/meson.build | 12 ++++++++++++ > > 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 > > drivers/crypto/virtio/meson.build > > > > diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build > > index > > 736c9f5..63649c9 100644 > > --- a/drivers/crypto/meson.build > > +++ b/drivers/crypto/meson.build > > @@ -2,7 +2,7 @@ > > # Copyright(c) 2017 Intel Corporation > > > > drivers = ['dpaa_sec', 'dpaa2_sec', > > - 'openssl', 'null', 'qat'] > > + 'openssl', 'null', 'qat', 'virtio'] > > > > std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps > > config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' > > diff --git a/drivers/crypto/virtio/meson.build > > b/drivers/crypto/virtio/meson.build > > new file mode 100644 > > index 0000000..cee77cc > > --- /dev/null > > +++ b/drivers/crypto/virtio/meson.build > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 HUAWEI > > +TECHNOLOGIES CO., LTD. > > + > > +dep = dependency('libcrypto', required: false) if not dep.found() > > + build = false > > +endif > > +deps += ['bus_pci'] > > +sources = files('virtio_cryptodev.c', 'virtio_pci.c', > > + 'virtio_rxtx.c', 'virtqueue.c') > > +ext_deps += dep > > +pkgconfig_extra_libs += '-lcrypto' > > -- > > 1.8.3.1 > > > > Could you add this build from the first patch? Basically, every time you make > a change in the Makefile, you should do the same in meson.build.
I'll split this patch into two parts and squash them into the first and the second patch. Thanks for your suggestion. Regards, Jay > > Thanks, > Pablo
