On 04/16/2018 06:33 PM, Olivier Matz wrote:
On Mon, Apr 16, 2018 at 02:24:33PM +0100, Andrew Rybchenko wrote:
Size of memory chunk required to populate mempool objects depends
on how objects are stored in the memory. Different mempool drivers
may have different requirements and a new operation allows to
calculate memory size in accordance with driver requirements and
advertise requirements on minimum memory chunk size and alignment
in a generic way.

Bump ABI version since the patch breaks it.

Suggested-by: Olivier Matz <olivier.m...@6wind.com>
Signed-off-by: Andrew Rybchenko <arybche...@solarflare.com>

@@ -643,39 +633,35 @@ rte_mempool_populate_default(struct rte_mempool *mp)
         * 1G page on a 10MB memzone). If we fail to get enough contiguous
         * memory, then we'll go and reserve space page-by-page.
-       no_pageshift = no_contig || force_contig ||
-                       rte_eal_iova_mode() == RTE_IOVA_VA;
+       no_pageshift = no_contig || rte_eal_iova_mode() == RTE_IOVA_VA;
        try_contig = !no_contig && !no_pageshift && rte_eal_has_hugepages();
In case there is a v5 for another reason, I think the last line is
equivalent to:

   try_contig = !no_pageshift && rte_eal_has_hugepages();

Agree. As I understand it is true before my patch as well.

Acked-by: Olivier Matz <olivier.m...@6wind.com>

Reply via email to