The destination string may not have a null termination if
the source string's length is equal to the sizeof(link->name).

Fix by replacing strncpy with strlcpy that guarantees NULL-termination.

Coverty issue: 272594
Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")

Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com>
---
 examples/ip_pipeline/link.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c
index 26ff41b..b8a431f 100644
--- a/examples/ip_pipeline/link.c
+++ b/examples/ip_pipeline/link.c
@@ -6,6 +6,7 @@
 #include <string.h>
 
 #include <rte_ethdev.h>
+#include <rte_string_fns.h>
 
 #include "link.h"
 #include "mempool.h"
@@ -236,7 +237,7 @@ link_create(const char *name, struct link_params *params)
        }
 
        /* Node fill in */
-       strncpy(link->name, name, sizeof(link->name));
+       strlcpy(link->name, name, sizeof(link->name));
        link->port_id = port_id;
        link->n_rxq = params->rx.n_queues;
        link->n_txq = params->tx.n_queues;
-- 
2.9.3

Reply via email to