Hi Thomas, In fact Meson compile enables all library builds so you cannot turn off cryptodev manually. So the condition checking to disable vhost crypto build is not necessary.
Regards, Fan > -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 16, 2018 10:43 PM > To: Zhang, Roy Fan <roy.fan.zh...@intel.com> > Cc: dev@dpdk.org; maxime.coque...@redhat.com; shah...@mellanox.com; > Richardson, Bruce <bruce.richard...@intel.com> > Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile > > 16/04/2018 16:08, Fan Zhang: > > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") > > > > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled. > > This patch fix this by adding checking to Makefile. > > > > Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com> > > --- > > lib/librte_vhost/Makefile | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > What about meson.build? > >
