On Tue, Apr 17, 2018 at 10:56:52PM +0200, Thomas Monjalon wrote:
> 17/04/2018 17:04, Xueming Li:
> > +struct rte_flow_item_vxlan_gpe {
> > + uint8_t flags; /**< Normally 0x0c (I and P flags). */
> > + uint8_t rsvd0[2]; /**< Reserved, normally 0x0000. */
> > + uint8_t protocol; /**< Protocol type. */
> > + uint8_t vni[3]; /**< VXLAN identifier. */
> > + uint8_t rsvd1; /**< Reserved, normally 0x00. */
> > +};
>
> These comments are not aligned.
Regarding this part: it's OK for rte_flow.h since it's the style used in
that file. Besides I favor it as it circumvents the entire alignemnt issue
altogether for subsequent contributions.
> > +struct vxlan_gpe_hdr {
> > + uint8_t vx_flags; /**< flag (8). */
> > + uint8_t reserved[2]; /**< Reserved (16). */
> > + uint8_t proto; /**< next-protocol (8). */
> > + uint32_t vx_vni; /**< VNI (24) + Reserved (8). */
> > +} __attribute__((__packed__));
>
> Alignment must be done with spaces.
>
>
--
Adrien Mazarguil
6WIND
