On 4/8/2018 3:42 AM, Qi Zhang wrote: > Add new command to setup queue: > queue setup (rx|tx) (port_id) (queue_idx) (ring_size) (offloads)
My almost classic comment for testpmd: Do we need a new high level command "queue setup" for this. Can't we extend existing port/queue setting commands for the sake of the usability. Each feature is trying to add its new command in its new syntax what suits to author. And why both (ring_size) and (offloads) set in same command, as far as I can see you can't ignore them, so to set ring_size I should know offloads for queue too, they don't look too related why setting together in same command. Isn't there any other command to set ring_size? I would be surprised if there is no. And there are a few new command for setting/getting offloads. Can't we re-use them?