> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of KamilX Chalupnik
> Sent: Wednesday, April 4, 2018 3:06 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokh...@intel.com>; Chalupnik, KamilX
> <kamilx.chalup...@intel.com>
> Subject: [dpdk-dev] [PATCH] app/bbdev: update test vectors
> From: "Chalupnik, KamilX" <kamilx.chalup...@intel.com>
> Update test vectors directory for Wireless Baseband Device:
> - creation of new vectors to test and validate BBDevice capabilities
> - python script used for tests execution updated
> Update the test app documentation:
> - vector test names updated
> - description of tests added
> - usage of test app updated
> Signed-off-by: KamilX Chalupnik <kamilx.chalup...@intel.com>

Could you split this patch into multiple patches? You are doing several things 
here, so it is better to split each thing into a different patch.
Make sure that the functionality and compilation is not broken for each patch.
I think you can have a patch updating the names of current tests (updating the 
documentation in the same patch),
another patch adding the new tests (also updating the documentation) and a last 
patch with the rest of the
documentation changes.
This way, it will be easier to review.

Also, another comment below.

> --- a/doc/guides/tools/testbbdev.rst
> +++ b/doc/guides/tools/testbbdev.rst


>    ./test-bbdev.py -p ../../x86_64-native-linuxapp-icc/app/testbbdev
> -  -v ./test_vectors/bbdev_vector_td_default.data
> +  -v turbo_dec_default.data

Shouldn't this be still under test_vectors?

Reply via email to