16/04/2018 15:05, Declan Doherty:
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> +/**
> + * Default values for switch domain id when ethdev does not support switch
> + * domain definitions.
values -> value
> + */
> +#define RTE_ETH_DEV_SWITCH_DOMAIN_ID_INVALID (0)
> +
> +/**
> + * Ethernet device associated switch information
> + */
> +struct rte_eth_switch_info {
> + const char *name; /**< switch name */
> + uint16_t domain_id; /**< switch domain id */
> + uint16_t port_id; /**< switch port id */
I feel we need more details about what is the "switch port id".
[...]
> @@ -1054,6 +1069,8 @@ struct rte_eth_dev_info {
> struct rte_eth_dev_portconf default_rxportconf;
> /** Tx parameter recommendations */
> struct rte_eth_dev_portconf default_txportconf;
> + /** ethdev switch information */
Can we reword it to express that it is about the hardware
built-in switch hard wired to this port?
> + struct rte_eth_switch_info switch_info;
> };
