buggtb commented on issue #135: Initial Commit of adding new UI designed with 
vue
URL: https://github.com/apache/drat/pull/135#issuecomment-406264661
 
 
   I'm trying to process the PR but its a bit hairy. I would say, you still 
seem to have a minified index.html and some javascript stuff in there, 
shouldn't they be .gitignored and build at build time?
   
   Also whats the licensing on those fonts you've added? I'm not sure we can 
check them in because of their binary nature. I'm sure @chrismattmann can tell 
me if I'm just making stuff up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to