-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28496/#review63799
-----------------------------------------------------------



exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
<https://reviews.apache.org/r/28496/#comment106109>

    These tests are failing for me. The tests are timezone sensitive, baseline 
is generated for PST and I am running on a VM with its timezone set to UTC. 
Please modify the test so that we get the current time zone information and use 
a library (joda) to get the milliseconds value.


- Mehant Baid


On Dec. 3, 2014, 11:17 p.m., Venkata krishnan Sowrirajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28496/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2014, 11:17 p.m.)
> 
> 
> Review request for drill and Mehant Baid.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Added functionality for unix_timestamp() similar to MySQL
> 
> 
> Diffs
> -----
> 
>   
> exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DateTypeFunctions.java
>  f063466 
>   
> exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestNewDateFunctions.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/28496/diff/
> 
> 
> Testing
> -------
> 
> Added testcases
> 
> 
> Thanks,
> 
> Venkata krishnan Sowrirajan
> 
>

Reply via email to