----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29064/#review65229 -----------------------------------------------------------
Ship it! Ship It! - Hanifi Gunes On Dec. 16, 2014, 6:28 p.m., Parth Chandra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29064/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 6:28 p.m.) > > > Review request for drill and Hanifi Gunes. > > > Repository: drill-git > > > Description > ------- > > CPP client asserts when the value vactor returned by the server contains only > nulls because the underlying sliced bytebuf class did not handle zero length > buffers. Also in some cases the server sends back an entire column with a > value count of zero instead of a nullable vector. > > > Diffs > ----- > > contrib/native/client/src/clientlib/recordBatch.cpp 2a679fa > contrib/native/client/src/include/drill/recordBatch.hpp 28377cb > contrib/native/client/src/protobuf/BitControl.pb.h 798da33 > contrib/native/client/src/protobuf/BitControl.pb.cc 64ab783 > contrib/native/client/src/protobuf/UserBitShared.pb.h cfe6938 > contrib/native/client/src/protobuf/UserBitShared.pb.cc 17b3463 > > Diff: https://reviews.apache.org/r/29064/diff/ > > > Testing > ------- > > > Thanks, > > Parth Chandra > >
