> On Jan. 2, 2015, 11:58 p.m., Jacques Nadeau wrote: > > I'm also confused. I was expecting cast safe functions to convert an empty > > string into a null numeric value. Is that functionality here?
Indeed, it is. But I also allowed users to choose to use the original cast function: More precisely, if you type in "alter session set planner.safe_cast_varchar = true", the new safe cast funtion (which casts an empty string into a null numeric value). Otherwise, planner.safe_cast_varchar is false by default. So the orignal cast function is chosen. - Sean Hsuan-Yi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29549/#review66566 ----------------------------------------------------------- On Jan. 2, 2015, 10:09 p.m., Sean Hsuan-Yi Chu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29549/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2015, 10:09 p.m.) > > > Review request for drill, Aman Sinha and Jinfeng Ni. > > > Bugs: DRILL-1874 > https://issues.apache.org/jira/browse/DRILL-1874 > > > Repository: drill-git > > > Description > ------- > > Users can choose to use safe (for varchar inputs)/default cast functions by > setting sesseion variable ("alter session set `planner.safe_cast_varchar` = > true;"). > > Add comments, Clean Codes > > > Diffs > ----- > > > common/src/main/java/org/apache/drill/common/expression/fn/CastFunctions.java > 61d149d > exec/java-exec/src/main/codegen/data/Casts.tdd 36c90c9 > exec/java-exec/src/main/codegen/templates/CastSafeFunctions.java > PRE-CREATION > exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java > b390cd5 > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/ExpressionTreeMaterializer.java > 0f40958 > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectRecordBatch.java > fa983aa > > exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptionManager.java > 34729e2 > > exec/java-exec/src/main/java/org/apache/drill/exec/store/text/DrillTextRecordReader.java > e0cce8b > > Diff: https://reviews.apache.org/r/29549/diff/ > > > Testing > ------- > > unit tests, > functional tests, > tpch tests > > > Thanks, > > Sean Hsuan-Yi Chu > >
