> On Jan. 3, 2015, 12:30 a.m., Parth Chandra wrote: > > contrib/native/client/src/include/drill/drillClient.hpp, line 266 > > <https://reviews.apache.org/r/28419/diff/1/?file=774784#file774784line266> > > > > Does this have to be static?
We use a static version of QueryResultListener callback function which then call this getApplicationContext function. It required this function to be static. Also I think this function should be independnet of drill client instance. - Xiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28419/#review66567 ----------------------------------------------------------- On Nov. 24, 2014, 10:45 p.m., Xiao Meng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28419/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 10:45 p.m.) > > > Review request for drill and Parth Chandra. > > > Bugs: DRILL-1776 > https://issues.apache.org/jira/browse/DRILL-1776 > > > Repository: drill-git > > > Description > ------- > > DRILL-1776: C++ Client. Add interface to get application context. > > > Diffs > ----- > > contrib/native/client/src/clientlib/drillClient.cpp > 70058ec360f404e473c497cbb86d5e53a98f5bbb > contrib/native/client/src/include/drill/drillClient.hpp > 65c07d6a95ca91e25ebbf165f4b54314b9916b22 > > Diff: https://reviews.apache.org/r/28419/diff/ > > > Testing > ------- > > This has been used in ODBC driver for a while, as discussed in DRILL-1537. > > > Thanks, > > Xiao Meng > >
