----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29816/#review67681 -----------------------------------------------------------
contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111763> The formatting seems inconsistent, I know Drill has been no standardized styling but let's at least get the same code to look the same. contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111764> What execptions can this throw? Why no catch at all? contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111768> You should be able to use for (ColumnDefintioins.Definition def : row.getColumnDefinitions()) contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111770> Do we don't throw DrillRuntimeExecption here too? I'm out of touch of storage engines, so just a question. contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111772> Stringg -> String typo contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java <https://reviews.apache.org/r/29816/#comment111771> I wonder if instanceof or something similiar is better than string comps - Timothy Chen On Jan. 12, 2015, 7:03 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29816/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 7:03 p.m.) > > > Review request for drill. > > > Repository: drill-git > > > Description > ------- > > Cassandra storage engine implementation using the datastax Java driver. > Storage plugin format: > { > "type": "cassandra", > "host": "localhost", > "port": 9042, > "enabled": true > } > > Sample Supported Queries: > SELECT id,pog_rank FROM cassandra.recsys.`trending_now` t; > SELECT * FROM cassandra.recsys.`trending_now` t WHERE id = 'id0004' and > pog_rank = 2; > > > Known Issues: > - Subscan doesnot use min/max filters, hence pulls entire data > - Filter pushdown is broken. Currently only Drill side filters work. > > > Diffs > ----- > > contrib/pom.xml d75dc79 > contrib/storage-cassandra/pom.xml PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraCompareFunctionsProcessor.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraDatabaseSchema.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraFilterBuilder.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraGroupScan.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraPushDownFilterForScan.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraRecordReader.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraScanBatchCreator.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraScanSpec.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraSchemaFactory.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraStoragePlugin.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraStoragePluginConfig.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/CassandraSubScan.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/DrillCassandraConstants.java > PRE-CREATION > > contrib/storage-cassandra/src/main/java/org/apache/drill/exec/store/cassandra/connection/CassandraConnectionManager.java > PRE-CREATION > contrib/storage-cassandra/src/main/resources/bootstrap-storage-plugins.json > PRE-CREATION > contrib/storage-cassandra/src/main/resources/drill-module.conf PRE-CREATION > > contrib/storage-cassandra/src/test/java/org/apache/drill/cassandra/BaseCassandraTest.java > PRE-CREATION > > contrib/storage-cassandra/src/test/java/org/apache/drill/cassandra/CassandraFilterPushdownTest.java > PRE-CREATION > > contrib/storage-cassandra/src/test/java/org/apache/drill/cassandra/CassandraProjectPushdownTest.java > PRE-CREATION > > contrib/storage-cassandra/src/test/java/org/apache/drill/cassandra/CassandraRecordReaderTest.java > PRE-CREATION > > contrib/storage-cassandra/src/test/java/org/apache/drill/cassandra/CassandraTestConstants.java > PRE-CREATION > > contrib/storage-cassandra/src/test/resources/cassandra-plans/cassandra_scan_screen_physical.json > PRE-CREATION > > contrib/storage-cassandra/src/test/resources/cassandra-plans/cassandra_scan_screen_with_columns_physical.json > PRE-CREATION > distribution/pom.xml 2aefe08 > distribution/src/assemble/bin.xml 8f6e90d > > Diff: https://reviews.apache.org/r/29816/diff/ > > > Testing > ------- > > Testing done via Sqlline and Web Interface. > Tested with Physical plan and Sql query via New Test framework. > > Testcases: > > CassandraRecordReaderTest > - testPlanLocal > - testPlanLocalWithColumns > > CassandraProjectPushdownTest > - testProjection > > CassandraFilterPushdownTest > - testSelectAll > - testFilter > - testFilter1 > - testFilter2 > - testFilterZeroRecords > - testFilterWithOrCondition > - testFilterWithAndCondition > > > Thanks, > > Yash Sharma > >
