-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29519/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 11:06 p.m.)
Review request for drill, Jacques Nadeau, Parth Chandra, and Steven Phillips.
Changes
-------
addressed the comments + refactored code to make it more robust and readable.
Bugs: DRILL-1885
https://issues.apache.org/jira/browse/DRILL-1885
Repository: drill-git
Description
-------
fix a problem regarding ordinal to vector mapping that report incorrect result
or fails a query.
fix failing unittest
refactor code, eliminate redundancy
Diffs (updated)
-----
common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java
23833b6
exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java
d50760a
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java
1210d90
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java
f126e5c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java
cc3d24c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
362d806
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
e140c8b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/VectorWithOrdinal.java
PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/ComplexWriterImpl.java
18b5e9e
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedListReaderImpl.java
c60730c
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/RepeatedMapReaderImpl.java
15f8a2b
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleListReaderImpl.java
c2284ec
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/SingleMapReaderImpl.java
3ec66ff
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/impl/VectorContainerWriter.java
36184a7
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java
8405d0e
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/fn/TestJsonReaderWithSparseFiles.java
7e4cf4b
exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestRepeated.java
3f125fa
Diff: https://reviews.apache.org/r/29519/diff/
Testing (updated)
-------
all test suites.
Thanks,
Hanifi Gunes
