-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30057/
-----------------------------------------------------------

Review request for drill and Parth Chandra.


Bugs: DRILL-2031
    https://issues.apache.org/jira/browse/DRILL-2031


Repository: drill-git


Description
-------

The reader for bit columns threw an index out of bounds exception reading some 
files. Rather than debug the complex code taht was there, falling back to the 
value by value interface provided by the parquet library. 


Diffs
-----

  
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/BitReader.java
 9aabc9c 
  exec/java-exec/src/test/java/org/apache/drill/DrillTestWrapper.java f06203e 
  
exec/java-exec/src/test/java/org/apache/drill/exec/HyperVectorValueIterator.java
 d214b7c 
  
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
 8ecb6c1 

Diff: https://reviews.apache.org/r/30057/diff/


Testing
-------

Unit test added verifies the changes, but is currently ignored. Will work on 
getting a number of files that have been used for parquet testing either 
uploaded to an online service and worked into the downloaded files for the 
build, or replace them with files generated at test time. This is now tracked 
as DRILL-2040 as the task has been outstanding for a long time.


Thanks,

Jason Altekruse

Reply via email to