----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30060/#review68684 -----------------------------------------------------------
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/NamedThreadFactory.java <https://reviews.apache.org/r/30060/#comment113034> We use this fully qualified in many many places. We also new package protected in many places. I'm inclined to stick with consistency with the rest of code rather than changing to private declaration and static import. exec/java-exec/src/main/java/org/apache/drill/exec/rpc/NamedThreadFactory.java <https://reviews.apache.org/r/30060/#comment113033> Remove all of this. I think it is wrong in the case of daemon. I think the max priority stuff is old debugging code. We'll need to run extra set of tests after removal, though. - Jacques Nadeau On Jan. 20, 2015, 12:55 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30060/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 12:55 a.m.) > > > Review request for drill, Jacques Nadeau and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Mainly, documented NamedThreadFactory. Also performed minor cleanup. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/NamedThreadFactory.java > 2b49579 > > Diff: https://reviews.apache.org/r/30060/diff/ > > > Testing > ------- > > Ran developer and QA tests; got no errors other than errors that appear for > master branch. > > > Thanks, > > Daniel Barclay > >
