----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29643/#review68932 -----------------------------------------------------------
Comment about the error message below. Also, doing this at operator level is too late...you would need to do this in the sql parsing stage. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameBatchCreator.java <https://reviews.apache.org/r/29643/#comment113461> Error message should say 'Window functions are not yet supported." (instead of disabled). - Aman Sinha On Jan. 21, 2015, 4:13 p.m., abdelhakim deneche wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29643/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 4:13 p.m.) > > > Review request for drill. > > > Bugs: DRILL-1912 > https://issues.apache.org/jira/browse/DRILL-1912 > > > Repository: drill-git > > > Description > ------- > > display "Window functions have been disabled" when a query contains an over > clause. But the following issues still arise and throw different exceptions: > DRILL-1863, DRILL-1862, DRILL-1852. Those issues seem to be caused by optiq > validation. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/StreamingWindowFrameBatchCreator.java > 9b8929f > > exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java > 7c04477 > > Diff: https://reviews.apache.org/r/29643/diff/ > > > Testing > ------- > > All tests pass correctly. > Tested manually several queries with over clause and got "Window functions > have been disabled" message. > > > Thanks, > > abdelhakim deneche > >
