> On Jan. 20, 2015, 2:52 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java, > > line 54 > > <https://reviews.apache.org/r/30059/diff/1/?file=825995#file825995line54> > > > > Synchronized is fine. You can remove comments.
Roger. > On Jan. 20, 2015, 2:52 a.m., Jacques Nadeau wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java, > > line 94 > > <https://reviews.apache.org/r/30059/diff/1/?file=825995#file825995line94> > > > > Yes, it should. Roger. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30059/#review68685 ----------------------------------------------------------- On Jan. 20, 2015, 12:45 a.m., Daniel Barclay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30059/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 12:45 a.m.) > > > Review request for drill, Jacques Nadeau and Jason Altekruse. > > > Repository: drill-git > > > Description > ------- > > Technical change: Added "synchronized" to increment(). > > Other changes: Documentation and renaming for clarity. > > > Diffs > ----- > > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/SendingAccountor.java > 7af7b65 > > Diff: https://reviews.apache.org/r/30059/diff/ > > > Testing > ------- > > Ran developer and QA tests; got no errors other than errors that appear for > master branch. > > > Thanks, > > Daniel Barclay > >
